fs: remove duplicate getValidatedPath calls #61359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61359 +/- ##
=======================================
Coverage 88.51% 88.52%
=======================================
Files 704 704
Lines 208739 208739
Branches 40274 40279 +5
=======================================
+ Hits 184770 184778 +8
- Misses 15968 15974 +6
+ Partials 8001 7987 -14
🚀 New features to boost your workflow:
|
BridgeAR
approved these changes
Jan 12, 2026
juanarbol
approved these changes
Jan 13, 2026
meixg
approved these changes
Jan 13, 2026
lpinca
approved these changes
Jan 13, 2026
cjihrig
approved these changes
Jan 13, 2026
github-actions
bot
removed
the
request-ci
Collaborator
anonrig
approved these changes
Jan 20, 2026
Collaborator
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 2cc10da |
aduh95
pushed a commit
that referenced
this pull request
Jan 22, 2026
PR-URL: #61359 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
islandryu
pushed a commit
to islandryu/node
that referenced
this pull request
Jan 25, 2026
PR-URL: nodejs#61359 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
already validated earlier in the function
https://github.com/nodejs/node/blob/main/lib/fs.js#L1635